fix(monitor): system monitor loading issue with clang-llvm 18 #1897
+47
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rksharma95 relay latest updated. |
Signed-off-by: rksharma95 <[email protected]> system monitor should compile using any version 10^ of clang-llvm tool and should load on any kernel 4.18^, it needs more restrictive bound checks on earlier versions of ebpf verifier. Signed-off-by: rksharma95 <[email protected]>
rksharma95
force-pushed
the
fix-clang18-bug
branch
from
9c3a1dc
to
f8066c7
Compare
rksharma95
changed the title
rksharma95
requested review from
daemon1024,
Aryan-sharma11,
DelusionalOptimist and
rootxrishabh
DelusionalOptimist
approved these changes
Nov 25, 2024
rootxrishabh
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
system monitor was failing to load when compiling using clang-llvm tool v18. This PR fixes this issue.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Manually Tested on following environments:
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>